SKS-Keyserver / sks-keyserver

OpenPGP keyserver
GNU General Public License v2.0
133 stars 15 forks source link

Better error message if search limit exceeded #43

Closed ygrek closed 4 years ago

ygrek commented 8 years ago

Original report by Dmitry Bolshakov (Bitbucket: bdimych, GitHub: bdimych).


http://zimmermann.mayfirst.org:11371/pks/lookup?search=Bitcoin&op=vindex
"Error handling request. Exception raised."

http://zimmermann.mayfirst.org:11371/pks/lookup?search=Bitcoin+Core&op=vindex
results displayed

I asked
http://security.stackexchange.com/questions/135197/gpg-server-hides-search-results
and decided to write this bug - why not just print clear message "limit exceeded" ?

wiml commented 4 years ago

It looks like the problem is just the scope of the try ... with block in handle_get_request in dbserver.ml. There is code there to translate the exception into a clearer error message, but the exception is thrown a few lines before the try, and so it doesn't get caught.

ygrek commented 4 years ago

thanks