search

SKalt / git-cc

a git extension to help write conventional commits
Other
83 stars 8 forks source link

Navigation with Ctrl+n/p #33

Closed dlvhdr closed 1 year ago

dlvhdr commented 1 year ago

In addition to up/down

SKalt commented 1 year ago

since j and k are both valid letters, implementing j/k navigation would require adding a navigation mode that's distinct from the current default prefix-search mode. I'm unwilling to do that, but I'd accept a PR with an appropriate change as long as all commits in the PR have a DCO. I know the devs at Charmbracelet recently updated their default helpbar and list-navigation components in the bubbles repo, so reviewing those would be a good place to start.

dlvhdr commented 1 year ago

Oh yeah... how about ctrl+n/p? That's standard in vim as well, also fzf

SKalt commented 1 year ago

Key combos wouldnt add as much complexity as full-on modal navigation! I'll put this issue on my agenda.

On Sat, Feb 18, 2023, 16:12 Dolev Hadar @.***> wrote:

Oh yeah... how about ctrl+n/p? That's standard in v as well

— Reply to this email directly, view it on GitHub https://github.com/SKalt/git-cc/issues/33#issuecomment-1435770118, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACPUNZI635TAE3CM7V3RR7TWYE3NVANCNFSM6AAAAAAVAQC6DU . You are receiving this because you modified the open/close state.Message ID: @.***>

SKalt commented 1 year ago

If you install the most recent version (0.0.16), the ctrl+p/ctrl+n functionality should be present.