search

SKopecz / PositiveIntegrators.jl

A Julia library of positivity-preserving time integration methods
https://skopecz.github.io/PositiveIntegrators.jl/
MIT License
13 stars 4 forks source link

improve performance with sparse matrices #101

Closed ranocha closed 2 months ago

ranocha commented 2 months ago

Closes #98

codecov-commenter commented 2 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 96.85864% with 6 lines in your changes missing coverage. Please review.

Project coverage is 98.09%. Comparing base (4fdc654) to head (1d157ca). Report is 1 commits behind head on main.

Files Patch % Lines
src/mprk.jl 95.20% 6 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #101 +/- ## ========================================== - Coverage 98.32% 98.09% -0.23% ========================================== Files 6 6 Lines 1250 1415 +165 ========================================== + Hits 1229 1388 +159 - Misses 21 27 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ranocha commented 2 months ago

There seem to be some issues with floating point rounding errors on macOS CI. The other tests seem to be fine

ranocha commented 2 months ago

@SKopecz Do you have an idea why MPRK43II may be so sensitive here - or how we should fix it?

SKopecz commented 2 months ago

@SKopecz Do you have an idea why MPRK43II may be so sensitive here - or how we should fix it?

If possible, I'd exclude MPRK43II from this specific test on macOS for now and create an issue to deal with this later.

I think we need much more information to see what the actual problem is. It looks to me as if the result of linear solve has a negative element.

ranocha commented 2 months ago

@SKopecz Do you have an idea why MPRK43II may be so sensitive here - or how we should fix it?

If possible, I'd exclude MPRK43II from this specific test on macOS for now and create an issue to deal with this later.

👍

I think we need much more information to see what the actual problem is. It looks to me as if the result of linear solve has a negative element.

Yes, that's what I think, too - computing the powers like σ^(1 - q1) * u^q1 seems to be the problem when σ becomes slightly negative

ranocha commented 2 months ago

This PR is ready for a review. Let's keep fingers crossed that CI passes this time 🤞