search

SKopecz / PositiveIntegrators.jl

A Julia library of positivity-preserving time integration methods
https://skopecz.github.io/PositiveIntegrators.jl/
MIT License
13 stars 4 forks source link

`alias_A` depending on sparsity #106

Open ranocha opened 3 months ago

ranocha commented 3 months ago

See https://github.com/SKopecz/PositiveIntegrators.jl/pull/101#discussion_r1682703182

However, I do not think that the linear solvers for sparse matrices change the sparse matrix as you fear. But we can check how it looks like with the change you have proposed. If the performance is not affected significantly, we can stay on the safe side.

codecov-commenter commented 3 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.09%. Comparing base (f86c263) to head (0fd135d).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #106 +/- ## ======================================= Coverage 98.09% 98.09% ======================================= Files 6 6 Lines 1414 1414 ======================================= Hits 1387 1387 Misses 27 27 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.