SKopecz / PositiveIntegrators.jl

A Julia library of positivity-preserving time integration methods
https://skopecz.github.io/PositiveIntegrators.jl/
MIT License
13 stars 4 forks source link

implement `get_tmp_cache` #113

Closed ranocha closed 3 months ago

ranocha commented 3 months ago

This function is required for some interoperability with Trixi.jl.

CC @jmbender

codecov-commenter commented 3 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.09%. Comparing base (6845b50) to head (787d8a5).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #113 +/- ## ======================================= Coverage 98.09% 98.09% ======================================= Files 6 6 Lines 1414 1420 +6 ======================================= + Hits 1387 1393 +6 Misses 27 27 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ranocha commented 3 months ago

Do you understand the error below, @SKopecz?

┌ Error: failed to run `@example` block in src/index.md:173-178
│ ```@example SIR
│ using Plots
│ 
│ plot(sol, label = ["S" "I" "R"], legend=:right)
│ plot!(sol, idxs = ((t, S, I, R) -> (t, S + I + R), 0, 1, 2, 3), label = "S+I+R") #Plot S+I+R over time.
│ ```
│   exception =
│    Incorrect specification of `idxs`

I have not changed this part of the docs and it worked before...

JoshuaLampert commented 3 months ago

You could test that by forcing SciMLBase@2.44.0.

ranocha commented 3 months ago

Good idea. It's running in #114

ranocha commented 3 months ago

Yes, that's the issue: https://github.com/SciML/SciMLBase.jl/issues/746

ranocha commented 3 months ago

Re-running CI so that we can check the results with the latest version of SciML including a bug fix.

ranocha commented 3 months ago

No, didn't help...

SKopecz commented 3 months ago

I'd suggest to discard the line plot!(sol, idxs = ((t, S, I, R) -> (t, S + I + R), 0, 1, 2, 3), label = "S+I+R") in the docs. I find the syntax idxs = ((t, S, I, R) -> (t, S + I + R), 0, 1, 2, 3) rather cumbersome. Instead we could use something like

plot!(sol.t,sum.(sol.u), label = "S+I+R")
ranocha commented 3 months ago

I'd suggest to discard the line plot!(sol, idxs = ((t, S, I, R) -> (t, S + I + R), 0, 1, 2, 3), label = "S+I+R") in the docs. I find the syntax idxs = ((t, S, I, R) -> (t, S + I + R), 0, 1, 2, 3) rather cumbersome. Instead we could use something like

plot!(sol.t,sum.(sol.u), label = "S+I+R")

Done in https://github.com/SKopecz/PositiveIntegrators.jl/pull/113/commits/787d8a5a73b7bf3e89b0b058d388090cddd94b9e