search

SKopecz / PositiveIntegrators.jl

A Julia library of positivity-preserving time integration methods
https://skopecz.github.io/PositiveIntegrators.jl/
MIT License
13 stars 4 forks source link

Implementation of `get_fsalfirstlast` for MPRK schemes #119

Closed SKopecz closed 2 months ago

SKopecz commented 2 months ago

Due to a change in OrdinaryDiffEq in-place problems cannot be solved currently. 

solve(prob_pds_linmod_inplace, MPE(); dt=0.1)

ERROR: MethodError: no method matching get_fsalfirstlast(::MPEConservativeCache{…}, ::Vector{…})
SKopecz commented 2 months ago

To solve the problem, I tried something similar to https://github.com/SciML/OrdinaryDiffEq.jl/blob/master/lib/OrdinaryDiffEqRKN/src/rkn_caches.jl. But it doesn't work.

@ranocha What am I doing wrong? How do we solve this problem?

codecov-commenter commented 2 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.24%. Comparing base (719311e) to head (b3682ac).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #119 +/- ## ======================================= Coverage 98.24% 98.24% ======================================= Files 7 7 Lines 1537 1538 +1 ======================================= + Hits 1510 1511 +1 Misses 27 27 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

SKopecz commented 2 months ago

@ranocha Found the problem. I didn't import get_fsalfirstlast from OrdinaryDiffEq.