SKopecz / PositiveIntegrators.jl

A Julia library of positivity-preserving time integration methods
https://skopecz.github.io/PositiveIntegrators.jl/
MIT License
13 stars 4 forks source link

Use `p_prototype` also in `MPE` #58

Closed JoshuaLampert closed 5 months ago

JoshuaLampert commented 5 months ago

In https://github.com/SKopecz/PositiveIntegrators.jl/pull/48, p_prototype is used for MPRK22, but not for MPE. However, I think we could also use the prototype for MPE to get some performance improvement, e.g. for Tridiagonal matrices, there. With this change, I was able to reduce the time from ~15 ms to ~5 ms for an equation with Tridiagonalstructure.

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.43%. Comparing base (ccb5b8c) to head (5dbaeef). Report is 23 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #58 +/- ## ========================================== + Coverage 98.14% 98.43% +0.28% ========================================== Files 4 4 Lines 378 446 +68 ========================================== + Hits 371 439 +68 Misses 7 7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.