search

SKopecz / PositiveIntegrators.jl

A Julia library of positivity-preserving time integration methods
https://skopecz.github.io/PositiveIntegrators.jl/
MIT License
13 stars 4 forks source link

Sk mprk43 #73

Closed SKopecz closed 6 months ago

SKopecz commented 6 months ago

Implementation of MPRK43I and MPRK43II for the solution of a ConservativePDSProblem (currently only out-of-place).

codecov-commenter commented 6 months ago

Codecov Report

Attention: Patch coverage is 99.08257% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 98.01%. Comparing base (00fe63a) to head (3d07f9e).

Files Patch % Lines
src/mprk.jl 99.08% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #73 +/- ## ========================================== + Coverage 97.17% 98.01% +0.84% ========================================== Files 4 4 Lines 495 604 +109 ========================================== + Hits 481 592 +111 + Misses 14 12 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ranocha commented 6 months ago

The spell checker is complaining about the reference "Numer Math" - maybe write out the journal in full?

ranocha commented 6 months ago

Thanks for your review, @JoshuaLampert!

JoshuaLampert commented 6 months ago

I think a short comment in the docstrings of MPRK43I and MPRK43II explaining the connection between these two schemes would help.

SKopecz commented 6 months ago

Thanks a lot! We can merge this PR from my point of view as it is - but we should remmeber to add some tests to the test directory as well. We can either do this in this PR or later - up to you, @SKopecz

I will add the tests.