search

SKopecz / PositiveIntegrators.jl

A Julia library of positivity-preserving time integration methods
https://skopecz.github.io/PositiveIntegrators.jl/
MIT License
13 stars 4 forks source link

Sk/mpe nonconservative #80

Closed SKopecz closed 5 months ago

SKopecz commented 5 months ago

This will implement MPE for nonconservative PDS, i.e. for PDSFunctions.

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.35%. Comparing base (1403775) to head (2d426d0). Report is 1 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #80 +/- ## ========================================== + Coverage 98.24% 98.35% +0.11% ========================================== Files 4 4 Lines 627 670 +43 ========================================== + Hits 616 659 +43 Misses 11 11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

SKopecz commented 5 months ago

I think this PR can be merged. It provides the possibility to solve nonconservative PDS with MPE.

In an upcoming PR I would try to free the caches MPEConservativeCache and MPECache from unnecessary fields.

ranocha commented 5 months ago

Nice! I just have two minor comments for now.