search

SKopecz / PositiveIntegrators.jl

A Julia library of positivity-preserving time integration methods
https://skopecz.github.io/PositiveIntegrators.jl/
MIT License
13 stars 4 forks source link

Sk/mpe caches #82

Closed SKopecz closed 3 months ago

SKopecz commented 3 months ago

Don't know if we actually want to merge this. Just wanted to see which fields in the caches are necessary.

Removed unnecessary fields from caches. Removed dolinsolve for MPE.

@ranocha Do you haven an opinion on this?

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.19%. Comparing base (1f36397) to head (aec7c96).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #82 +/- ## ========================================== - Coverage 98.35% 98.19% -0.17% ========================================== Files 4 4 Lines 670 665 -5 ========================================== - Hits 659 653 -6 - Misses 11 12 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

SKopecz commented 3 months ago

Okay, then let us merge this PR. I'll clean up the caches of the other schemes after implementing the solvers for nonconservative PDS in an upcoming PR.

ranocha commented 3 months ago

You need to mark this PR as ready for review - draft PRs cannot be merged