Implementation of MPRK22 and MPRK43 for nonconservative PDS (includes cleaning up the caches)

SKopecz / PositiveIntegrators.jl

A Julia library of positivity-preserving time integration methods

https://skopecz.github.io/PositiveIntegrators.jl/

MIT License

13 stars 4 forks source link

Implementation of MPRK22 and MPRK43 for nonconservative PDS (includes cleaning up the caches) #85

Closed SKopecz closed 4 months ago

SKopecz commented 4 months ago

Removed unnecessary code in initialize!for out-of-place MPE.
Added tests to check that zero initial values don't cause division by zero.
Added tests to check that division by zero is avoided for problems with solutions that tend monotonically to zero.
Implemented MPRK22 and MPRK43 for nonconservative PDS.
Removed dolinsolve in MPRK22 and MPRK43.
Cleaned caches of MPRK22 and MPRK43.
Added tests for MPRK22 and MPRK43 solving nenconservative PDS.
Removed hacks for preconditioners.

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.46%. Comparing base (52fe8ec) to head (8a48388).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #85 +/- ## ========================================== - Coverage 97.83% 97.46% -0.37% ========================================== Files 4 4 Lines 692 830 +138 ========================================== + Hits 677 809 +132 - Misses 15 21 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

SKopecz commented 4 months ago

Increased version number from 0.1.13 to 0.1.14. Is that okay?

If we stick to Semantic Versioning 2.0.0, then 0.2.0 is perhaps the better choice as new functionality (solution of nonconservative PDS) was added.

ranocha commented 4 months ago

Increased version number from 0.1.13 to 0.1.14. Is that okay?

This is fine 👍

If we stick to Semantic Versioning 2.0.0, then 0.2.0 is perhaps the better choice as new functionality (solution of nonconservative PDS) was added.

Julia uses a special interpretation of semantic versioning for version numbers of the form v0.Y.Z. In this case, increasing Y is a breaking change. Thus, if we want to stick with v0.Y.Z for now, it has to be v0.1.14 since it's not breaking.