search

SKopecz / PositiveIntegrators.jl

A Julia library of positivity-preserving time integration methods
https://skopecz.github.io/PositiveIntegrators.jl/
MIT License
13 stars 4 forks source link

SSPMPRK schemes. #86

Closed SKopecz closed 2 months ago

SKopecz commented 2 months ago
codecov-commenter commented 2 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 94.74790% with 25 lines in your changes missing coverage. Please review.

Project coverage is 97.12%. Comparing base (9eec12e) to head (bd6cdca). Report is 2 commits behind head on main.

Files Patch % Lines
src/mprk.jl 62.50% 12 Missing :warning:
src/sspmprk.jl 98.29% 7 Missing :warning:
src/interpolation.jl 82.35% 6 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #86 +/- ## ========================================== - Coverage 97.46% 97.12% -0.35% ========================================== Files 4 6 +2 Lines 830 1250 +420 ========================================== + Hits 809 1214 +405 - Misses 21 36 +15 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

SKopecz commented 2 months ago

Current status: The tests show that SSPMPRK43 is only first order accurate for nonconservative PDS (in-place as well as out-of-place). For conservative PDS the expected order can be seen (although the tests fail). Todo:

SKopecz commented 2 months ago

We still need to update the docstrings with respect to the choice of small_constant. What shall we write? I think we don't want to write that you can pass a function which is then evaluated as small_constant(uEltypeNoUnits)

ranocha commented 2 months ago

I think it's fine to explain the version you have suggested: either do not touch it to get floatmin of the relevant floating point type or pass a value explicitly.