typo - Githubissues

SLACKHA / pyJac

Creates C and CUDA analytical Jacobians for chemical kinetics ODE systems

http://slackha.github.io/pyJac/

MIT License

52 stars 23 forks source link

Closed skyreflectedinmirrors closed 6 years ago

skyreflectedinmirrors commented 6 years ago

Two minor bugs I encountered re-running performance data for the new paper.

The first is just a silly mistake I made in fixing #26 (is_pdep -> pdep)
The second has to do with an environment change on the testing machine, NVCC is now off the path such that I don't detect NVIDIA's OpenCL runtime (and this breaks the poorly formatted subprocess call, which should be fixed anyways)

kyleniemeyer commented 6 years ago

should bump the minor version number and issue a new release after merging this

kyleniemeyer commented 6 years ago

which reminds me, please update the CHANGELOG 😄

skyreflectedinmirrors commented 6 years ago

@kyleniemeyer I think you need to issue the release IIRC, it's on your pypi account. I updated the changelog and version

kyleniemeyer commented 6 years ago

I can do it, but the pip/conda release is done by Travis when it detects a new version tag, so it doesn't matter who does it.

skyreflectedinmirrors commented 6 years ago

@kyleniemeyer not sure if that triggered it?