search

SLOKnightfall / BetterWardrobe

31 stars 15 forks source link

Appearances tab missing ElvUI skin, small issue with preview window #251

Closed ryanull24 closed 2 years ago

ryanull24 commented 2 years ago

I looked it up and found a post on Reddit about a year ago saying ElvUI was supported. I don't know if the issue is on my end, but the Appearances tab looks like this to me. Looks like the default UI.

image image

Preview window (Dressing room) looks fine for the most part, except for the overlapping "No Outfit" and duplicate (?) save button

image

pesrou commented 2 years ago

Disable the ElvUI skin for Collections and Dressing Room, that should fix the last issue

SLOKnightfall commented 2 years ago

Fixed dressingroom elvui issues

ellaerror commented 2 years ago

Hi, I found a solution to this issue. In Plugins/ElvUI.lua of BetterWardrobe there's this code on line 505:

if not IsAddOnLoaded("Blizzard_Collections") then
    LoadAddOn("Blizzard_Collections")
    C_Timer.After(2, UpdateCollectionFrames)

end

By changing the code to this:

if not IsAddOnLoaded("Blizzard_Collections") then
    LoadAddOn("Blizzard_Collections")

end

C_Timer.After(2, UpdateCollectionFrames)

the issue no longer happens, at least for me. I believe this is because rarity gets loaded first and they also load the addon "Blizzard_Collections" (Rarity/Core/Collections.lua). By doing this, the function IsAddOnLoaded("Blizzard_Collections") returns true, which causes the UpdateCollectionFrames to never be called. I hope this helps.