SLOKnightfall / BetterWardrobe

30 stars 14 forks source link

OnTooltipSetItem Issue #398

Closed VladiO closed 10 months ago

VladiO commented 10 months ago

Crash on start.

OnTooltipSetItem was removed/changed with 10.0.2

https://us.forums.blizzard.com/en/wow/t/ontooltipsetitem/1405311 https://wowpedia.fandom.com/wiki/Patch_10.0.2/API_changes#Tooltip_Changes

1x GameTooltip:HookScript(): Doesn't have a "OnTooltipSetItem" script
[string "=[C]"]: in function `?'
[string "@LegionWardrobe/LegionTransmog.lua"]:3923: in main chunk

Locals:
(*temporary) = GameTooltip {
 0 = <userdata>
 SetQuestPartyProgress = <function> defined @SharedXML/Tooltip/TooltipDataHandler.lua:539
 ProcessLineData = <function> defined @SharedXML/Tooltip/TooltipDataHandler.lua:410
 shoppingTooltips = <table> {
 }
 SetPvpTalent = <function> defined @SharedXML/Tooltip/TooltipDataHandler.lua:539
 SetRuneforgeResultItem = <function> defined @SharedXML/Tooltip/TooltipDataHandler.lua:539
 HasDataInstanceID = <function> defined @SharedXML/Tooltip/TooltipDataHandler.lua:514
 SetUnit = <function> defined @SharedXML/Tooltip/TooltipDataHandler.lua:539
 SetAzeriteEssence = <function> defined @SharedXML/Tooltip/TooltipDataHandler.lua:539
 updateTooltipTimer = 0.200000
 SetTotem = <function> defined @SharedXML/Tooltip/TooltipDataHandler.lua:539
 SetVoidWithdrawalItem = <function> defined @SharedXML/Tooltip/TooltipDataHandler.lua:539
 ItemTooltip = Frame {
 }
 StatusBar = GameTooltipStatusBar {
 }
 SetBuybackItem = <function> defined =[C]:-1
 SetInfoBackdropStyle = <function> defined @SharedXML/Tooltip/TooltipDataHandler.lua:492
 GetPrimaryTooltipData = <function> defined @SharedXML/Tooltip/TooltipDataHandler.lua:499
 TextRight1 = GameTooltipTextRight1 {
 }
 SetSocketGem = <function> defined @SharedXML/Tooltip/TooltipDataHandler.lua:539
 SetEnhancedConduit = <function> defined @SharedXML/Tooltip/TooltipDataHandler.lua:539
 RefreshData = <function> defined @FrameXML/GameTooltip.lua:1055
 SetPetAction = <function> defined @SharedXML/Tooltip/TooltipDataHandler.lua:539
 SetLootCurrency = <function> defined @SharedXML/Tooltip/TooltipDataHandler.lua:539
 SetSlottedKeystone = <function> defined @SharedXML/Tooltip/TooltipDataHandler.lua:539
 SetWorldCursor = <function> defined @FrameXML/GameTooltip.lua:1074
 SetLootItem = <function> defined =[C]:-1
 SetItemKey = <function> defined @SharedXML/Tooltip/TooltipDataHandler.lua:539
 GetSpell = <function> defined @FrameXML/GameTooltip.lua:1112
 SetOwnedItemByID = <function> defined @SharedXML/Tooltip/TooltipDataHandler.lua:539
 supportsItemComparison = true
 SetQuestLogSpecialItem = <function> defined @SharedXML/Tooltip/TooltipDataHandler.lua:539
 supportsDataRefresh = true
 SetEquipmentSet = <function> defined @SharedXML/Tooltip/TooltipDataHandler.lua:539
 SetRecipeReagentItem = <function> defined @SharedXML/Tooltip/TooltipDataHandler.lua:539
 SetQuestCurrency = <function> defined @SharedXML/Tooltip/TooltipDataHandler.lua:539
 SetTransmogrifyItem = <function> defined @SharedXML/Tooltip/TooltipDataHandler.lua:539
 SetWeeklyReward = <function> defined @SharedXML/Tooltip/TooltipDataHandler.lua:539
 SetMerchantItem = <function> defined =[C]:-1
 SetPvpBrawl = <function> defined @SharedXML/Tooltip/TooltipDataHandler.lua:539
 GetUnit = <function> defined @FrameXML/GameTooltip.lua:1116
 BottomOverlay = Texture {
 }
 SetSpellByID = <function> defined @SharedXML/Tooltip/TooltipDataHandler.lua:539
 OnLoad = <function> defined @FrameXML/GameTooltip.lua:1049
 SetSocketedRelic = <function> defined @SharedXML/Tooltip/TooltipDataHandler.lua:539
 ProcessInfo = <function> defined @SharedXML/Tooltip/TooltipDataHandler.lua:335
 ProcessLines = <function> defined @SharedXML/Tooltip/TooltipDataHandler.lua:400
 NineSlice = Frame {
 }
 SetInventoryItem = <function> defined =[C]:-1
 SetTalent = <function> defined @SharedXML/Tooltip/TooltipDataHandler.lua:539
 SetCompanionPet = <function> defined @SharedXML/Tooltip/TooltipDataHandler.lua:539
 SetLootRollItem = <function> defined =[C]:-1
 SetAzeriteEssenceSlot = <function> defined @SharedXML/Tooltip/TooltipDataHandler.lua:539
 InternalProcessInfo = <function> defined @SharedXML/Tooltip/TooltipDataHandler.lua:339
 SetUnitDebuffByAuraInstanceID = <function> defined @
SLOKnightfall commented 10 months ago

I just checked and Betterwardrobe doesn't use that call. Looking at the error log its being caused by the LegionWardrobe addon

VladiO commented 10 months ago

You are absolutely right, I'm so sorry to have bothered you.

I mixed up the two addons. Thanks again for writing your addon and doing such fast support and reacting to (wrong) reports.

Cheers, keep up the awesome work.

SLOKnightfall commented 10 months ago

@VladiO No worries, it was good to check anyway :)