SLUGSoc / website

Reimplementation of new site in Ruby on Rails
2 stars 1 forks source link

Reduce or remove query string from resources #32

Closed Aterfax closed 5 years ago

Aterfax commented 6 years ago

Some caching software will not cache any files served with a query string. If the number of these assets can be reduced or query strings removed that would remove this issue.

image

boardfish commented 6 years ago

I'm noticing that all of these are JS files. For now, I think only Bootstrap makes use of those (as seen in the bootstrap/rails-ujs/popper mentions), as we don't currently stock any page-specific JS, even if there's scope for it (probably in app/assets/javascripts/). How major of an issue would you consider this to be?

Aterfax commented 6 years ago

Well, in theory getting rid of the theory string would be straightforward (I would have thought an easy fix) - but in terms of needed - it would be optimal (but hardly urgent) for reducing redownloads of all those files on subsequent reloads of the site since some web browsers will not cache it as is.

boardfish commented 5 years ago

Withdrawing this issue - I don't think it significantly contributes to user experience.