SLikeSoft / SLikeNet

SLikeNetâ„¢ is an Open Source/Free Software cross-platform network engine written in C++ and specifially designed for games (and applications which have comparable requirements on a network engine like games) building upon the discontinued RakNet network engine which had more than 13 years of active development.
https://www.slikenet.com/
Other
401 stars 63 forks source link

improvement::need a directory where to put unit test codes #27

Closed Kiddinglife closed 6 years ago

Kiddinglife commented 6 years ago

Raknet 's existing test are all integrity and system tests but it really needs to be carefully unit-tested especially for the base modules like data structure, bitstream, reliable_layer, sick connection cases and much much more ....

Luke1410 commented 6 years ago

We have set up such tests already in house and are improving the test coverage continuously. Before a release all the tests are being run to confirm nothing got broken. We are also working on a continuous test environment to run tests automatically prior to merging any pull request into the repository (atm this is still a manual process and hence not done for all pull requests/commits).

I'll put down a feature request regarding your point here to at least make a subset of the tests somehow available under the MIT license and get it integrated into the publicly available source code, so contributors have a way to verify no breakage of at least the basic functionality themselves. (internal case number: SLNET-133).

For the time being however, don't hesitate to sent in any pull requests. If we find anything wrong while passing them through through our tests, that the issues will be dealt with.

Kiddinglife commented 6 years ago

this works on me. cheers!