search

SLikeSoft / SLikeNet

SLikeNet™ is an Open Source/Free Software cross-platform network engine written in C++ and specifially designed for games (and applications which have comparable requirements on a network engine like games) building upon the discontinued RakNet network engine which had more than 13 years of active development.
https://www.slikenet.com/
Other
390 stars 62 forks source link

MinGW build failure #41

Open woollybah opened 5 years ago

woollybah commented 5 years ago

Platform: Win32, x64, MinGW 7.2

The MinGW build fails when it defines TCHAR, with an error in winnt.h...

https://github.com/SLikeSoft/SLikeNet/blob/70a86d11b7595b6ac64bdd261ce440ff35ad4a64/Source/include/slikenet/DR_SHA1.h#L178-L183

suggestion include

#if defined(_MSC_VER) || defined(__MINGW32__)

or

#ifdef _WIN32

Thanks!

Luke1410 commented 5 years ago

Thanks for the report.

Please note that we don't test / officially support MinGW atm (which is something we've got on our mid term roadmap - internal case number: SLNET-237). However, the suggested change obviously won't hurt and if it helps you, I'll apply the change right away to master.

Due to lack of other means to contact you, posting this here in the comment directly: To be legal wise on the safe side, we'd kindly ask you to accept our CLA: https://github.com/SLikeSoft/SLikeNet/blob/master/.github/CONTRIBUTING.md . Best send a short mail to the address specified there. Alternatively you can also simply reply here by comment. Also let us know whether we'd add a corresponding entry in the acknowledgement section for you.