Memory leaks in HTTPConnection2.cpp

[Tomash667]

HTTPConnection2 have some memory leaks. After adding request it must be processed and then user have to get response, otherwise it will leak (for example user quit game before response is received or processed).

Example solution:

HTTPConnection2::~HTTPConnection2()
{
    for(unsigned int i = 0, count = pendingRequests.Size(); i < count; ++i)
        SLNet::OP_DELETE(pendingRequests[i], _FILE_AND_LINE_);
    for(unsigned int i = 0, count = sentRequests.Size(); i < count; ++i)
        SLNet::OP_DELETE(sentRequests[i], _FILE_AND_LINE_);
    for(unsigned int i = 0, count = completedRequests.Size(); i < count; ++i)
        SLNet::OP_DELETE(completedRequests[i], _FILE_AND_LINE_);
}

I hereby declare I've read and agree to the current CLA as provided under https://github.com/SLikeSoft/SLikeNet/blob/master/.github/CONTRIBUTING.md

[Luke1410]

Hi Tomash, thanks for the report and the suggested fix. I've applied a variant of the suggested code change to the current trunk/master and the fix should be integrated in the next version of SLikeNet.

Internal issue number: SLNET-259.

Do you want to be listed in the acknowledgment section of the accompanied readme file as well for your contribution?

[Tomash667]

Sure, why not.