Multiple bug fixes, adds timeout option

SMAPPNYU / youtube-data-api

A Python Client for collect and parse public data from the Youtube Data API

MIT License

79 stars 31 forks source link

Closed richardARPANET closed 4 years ago

richardARPANET commented 4 years ago

Bugfix, _http_request() was sometimes returning a Boolean then timeout was reached, this caused AttributeError to be raised elsewhere in the codebase.
Instead of returning False when timeout reached, raise an exception, as per the zen of python "Errors should never pass silently."
Bugfix, double HTTP requests were being made, wasting API calls.

richardARPANET commented 4 years ago

@mabrownnyu could you review this? thanks