search

SMART-Lab / smartdispatch

An easy to use job launcher for supercomputers with PBS compatible job manager.
Do What The F*ck You Want To Public License
34 stars 18 forks source link

unique names for each job in multiple batches #144

Closed negar-rostamzadeh closed 7 years ago

negar-rostamzadeh commented 8 years ago

@mgermain regarding to the #11

negar-rostamzadeh commented 8 years ago

The test is failed as I changed the argument format in smart_dispatch? do you suggest to change the launcher in a different file that can be passed to the smart_dispatch script?

MarcCote commented 8 years ago

Of course, the unit tests should reflect the changes that were made.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 94.341% when pulling 2df5c5c3fab1208734ce07b3a925e12be3985825 on negar-rostamzadeh:edit_negar into f0793309f25b03e1a2dced75b51a19d5e31dc820 on SMART-Lab:master.

negar-rostamzadeh commented 8 years ago

sure, I will change it in the utils then. But I don't still understand why the name shouldn't be added through the options? Then it will be useful for the later changes to add the functionality of adding a manual name through options instead of just applying the default names.

On Mon, Nov 21, 2016 at 11:29 AM, Mathieu Germain notifications@github.com wrote:

@mgermain commented on this pull request.

In scripts/smart-dispatch https://github.com/SMART-Lab/smartdispatch/pull/144#pullrequestreview-9488398 :

@@ -128,6 +128,10 @@ def main(): }

 job_generator = job_generator_factory(queue, commands, command_params, CLUSTER_NAME, path_job)
  • for pbs in job_generator.pbs_list:
  • pbs.addoptions(options='-N ' + jobname + '' + str(i))

If you take a look at https://github.com/SMART-Lab/ smartdispatch/blob/master/smartdispatch/pbs.py#L58 you will see this will fail quite often. You should add a function in utils.py that takes a jobname and a id and return a string of length 64. Also, add a small test for that function.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/SMART-Lab/smartdispatch/pull/144#pullrequestreview-9488398, or mute the thread https://github.com/notifications/unsubscribe-auth/AKVH1rNDfmTtbVrLEUpKMem5GY_a4b53ks5rAcbogaJpZM4KwQJR .

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 94.341% when pulling bdc52e66bdd694bc6d43646297344ff49340d851 on negar-rostamzadeh:edit_negar into f0793309f25b03e1a2dced75b51a19d5e31dc820 on SMART-Lab:master.