Test for pbs files on slurm

SMART-Lab / smartdispatch

An easy to use job launcher for supercomputers with PBS compatible job manager.

Do What The F*ck You Want To Public License

34 stars 18 forks source link

Test for pbs files on slurm #166

Open aalitaiga opened 7 years ago

bouthilx commented 7 years ago

@aalitaiga You should rename pbs_slurm_test.py otherwise Travis will keep reporting failures. We could add --ignore-files= in .travis.yml but we don't want those tests to run locally neither. They are only usefull if we want to tests new settings on the slurm configuration, so they should only be ran alone. A name like verify_slurms_pbs_wrapper.py would be self-explanatory.

bouthilx commented 7 years ago

We need unit-tests for

[x] add_sbatch_flags
[x] add_sbatch_options
[x] ~~command line option~~
[x] job generator pbs file replacements (pnn, gpus, etc)

Make sure to test that what should pass, pass and what should fail fails. We need to try many different things to test the command line options. For instance, we need to try adding bad options or adding options already included by job generator. We need to make sure to test every cracks as this seems to me as an error-prone setup (replacing options for a framework by options a wrapper of another framework will recognize as what we want it to be for the latter framework :sweat:).