SMART-Lab / smartlearner

SMART-Learner is a machine learning library built with researchers in mind.
BSD 3-Clause "New" or "Revised" License
10 stars 4 forks source link

Preprocess interface + implementations #57

Closed ASalvail closed 8 years ago

ASalvail commented 8 years ago

First draft of Preprocess class and a couple implementations.

Any thoughts @MarcCote ?

ASalvail commented 8 years ago

This should do the trick!

MarcCote commented 8 years ago

This seems perfect but... could you add two small unit tests? One for NormalizeFeature and LagExample. That would really help me sleep at night :P.

ASalvail commented 8 years ago

Addressed @MarcCote comment. I removed the LagExample preprocessor because it really wasn't working as intended. (I actually don't know what it was doing...)