search

SMERM / EMUForm

Form for EMUFest submissions
GNU General Public License v2.0
1 stars 1 forks source link

GITTER SIDECAR BROKEN #64

Closed grammaton closed 8 years ago

grammaton commented 8 years ago

repaired with full script into _common_footer_cruft

  <!-- GITTER SIDECAR  -->
  <script>
    ((window.gitter = {}).chat = {}).options = {
      room: 'EMUFest/emufest.github.io'
    };
  </script>
  <script src="https://sidecar.gitter.im/dist/sidecar.v1.js" async defer></script>
  <!-- GITTER SIDECAR  -->
nicb commented 8 years ago

This is not the good fix. A proper fix is to invert the order of inclusion of javascripts in app/view/shared/_common_footer_cruft.html.erb:

<!-- emufest style -->
  <%= javascript_include_tag 'application', 'data-turbolinks-track' => true %>
  <!-- GITTER SIDECAR  -->
  <%= javascript_include_tag 'https://sidecar.gitter.im/dist/sidecar.v1.js' %>

since the javascript code mentioned is included from application.js, this will work - compressing/minimizing text and not including it twice.

grammaton commented 8 years ago

ok. done