SMFSW / Queue

Queue handling library (designed on Arduino)
BSD 3-Clause "New" or "Revised" License
93 stars 20 forks source link

Changed filenames, Classnames and fixed enum #13

Closed javto closed 2 years ago

javto commented 2 years ago

Thanks for doing the hard work of the Queue! However, I had some problems with it on Eclipse Sloeber IDE that didn't want to recognize the typedef enum (c) in the constructor. So I fixed that to make sure it's the usual enum class (cpp). I also fixed the naming of the class and files to match naming convention.

SMFSW commented 2 years ago

Thanks for your interest in Queue library.

That's strange, I tried to compile every example sketches in Sloeber IDE without getting any warning/error.

Do you have any example producing this error?

About naming conventions, they're fine, but may be a little confusing for Arduino users.

Thanks! Regards, SMFSW

javto commented 2 years ago

I'm sorry, I think it was a fluke on my side, after re-importing the project and re-attaching the libraries the error seems to be gone. As you've also indicated the name change is not so important for you I'll close this.

Again thanks for the hard work, I'm very happy to use your library!

SMFSW commented 2 years ago

You're welcome!

I'm glad it works fine, and that you are happy with the library.

Don't hesitate to raise an issue if you find something or something is missing in the library. With time, Most FIFO/LIFO possible functions and use cases are implemented, but some are maybe still missing.

About naming conventions, 2 points I did not explained last time:

Again, thank you for your feedback, Regards, SMFSW