search

SMH110 / widgets

1 stars 0 forks source link

addZero looks like it can be deleted #25

Closed massimocode closed 8 years ago

massimocode commented 8 years ago

It looks like addZero could be deleted and we could use addNumber instead. Again, best we wait until we have our automated tests in place before making this change.

SMH110 commented 8 years ago

Done here c38b14eca8648feedad5bcaa010a5e161c65a428

massimocode commented 8 years ago

I am reopening this issue because there was no need to copy the logic for addZero into addNumber and have both pieces of logic inside. It's very complicated and didn't need to be done. addZero could have simply been deleted and replaced with addNumber(0) because addNumber was enough.

SMH110 commented 8 years ago

Fixed here 5acdca5ae1e4babcfa9eec7065fb84b1869bccd9

SMH110 commented 8 years ago

Fixed in https://github.com/SMH110/My-Calculator/pull/28