search

SMH110 / widgets

1 stars 0 forks source link

Feature/fix #32

Closed SMH110 closed 8 years ago

massimocode commented 8 years ago

I've put a few comments on improvements you could make to the tests, but it does look much better overall. I'm confident we have some reasonably good test coverage. I would have stuck with using numbers rather than strings though. Is there any reason you went for strings?

SMH110 commented 8 years ago

I've put a few comments on improvements you could make to the tests, but it does look much better overall. I'm confident we have some reasonably good test coverage. I would have stuck with using numbers rather than strings though. Is there any reason you went for strings?

I said if I want to use number then I have to change the input of addNumber (n) to string then again to number before display it to the input= ko.observable.

massimocode commented 8 years ago

The changes are good. I've made the last one that was missing. Merging.