search

SMI / IsIdentifiable

A tool for detecting identifiable information in data sources (CSV, DICOM, Relational Database and MongoDB)
GNU General Public License v3.0
14 stars 3 forks source link

crash when scanning `MRSpectroscopyStorage` image #455

Open rkm opened 8 months ago

rkm commented 8 months ago

These shouldn't be scanned for Pixel Data, as they don't have any!

We should probably amend this:

https://github.com/SMI/IsIdentifiable/blob/main/IsIdentifiable/Runners/DicomFileRunner.cs#L235

Using the information fo-dicom provides on the SOPClassUID here:

https://github.com/fo-dicom/fo-dicom/blob/development/FO-DICOM.Core/DicomUID.cs#L31-L43

howff commented 8 months ago

Maybe just check for the PixelData tag being present?

If IsIdentifiable can also scan overlays then check for any of the 16 OverlayData tags being present?

rkm commented 8 months ago

Fair point 😉 I guess the question is whether we want to detect invalid files based on whether the SOPClass specifies pixel data should be present?

Not sure on the overlay handling - will check this.