search

SMI / RdmpDicom

Plugin for RDMP that adds support for load, linking (with EHR data in relational databases) and extracting anonymous DICOM images for researchers.
GNU General Public License v3.0
4 stars 4 forks source link

Unit tests don't actually test, because Windows. #416

Closed jas88 closed 3 months ago

jas88 commented 4 months ago

Describe the bug

Failures on Windows don't actually fail.

https://github.com/actions/runner-images/issues/6668

To Reproduce Steps to reproduce the behavior: Write a test that fails, like Assert.Fail(). Test will spuriously "pass" since exit code is ignored under pwsh unlike Bash.

Expected behavior Failing test should actually fail.

Screenshots If applicable, add screenshots to help explain your problem.

Additional context

Fortunately only an issue on Windows runners, which AIUI means only RDMP and RdmpDicom potentially affected.

jas88 commented 3 months ago

Fixed in #419