SMI / RdmpDicom

Plugin for RDMP that adds support for load, linking (with EHR data in relational databases) and extracting anonymous DICOM images for researchers.
GNU General Public License v3.0
4 stars 4 forks source link

Reject when tests fails this time #419

Closed jas88 closed 4 months ago

jas88 commented 4 months ago

Since the Github actions run on Windows under Powershell, the default is to ignore failures, which isn't really a very useful "test". This patch runs these steps under Bash instead, so failures actually fail the job, and adjusts the other steps to accommodate.

rkm commented 4 months ago

FYI you can also set bash as the default shell globally:

defaults:
  run:
    shell: bash