SMILEConsortium / node-smile-server

3 stars 4 forks source link

Add photo upload to SMILE Student Web #14

Closed truedat101 closed 10 years ago

truedat101 commented 11 years ago

Currently doesn't allow photo upload. We probably need to add a mim content uploader to our server. I'll take a look at what I've used in the past for this.

pinazo commented 11 years ago

Isn't it the base64 picture upload?


Juan Pinazo

On Thu, Apr 25, 2013 at 1:54 PM, truedat101 notifications@github.comwrote:

Currently doesn't allow photo upload. We probably need to add a mim content uploader to our server. I'll take a look at what I've used in the past for this.

— Reply to this email directly or view it on GitHubhttps://github.com/SMILEConsortium/node-smile-server/issues/14 .

truedat101 commented 11 years ago

Yes. You are right. The SMILE Student Web app doesn't handle image upload yet.

On Thu, Apr 25, 2013 at 3:14 PM, Juan Pinazo notifications@github.comwrote:

Isn't it the base64 picture upload?


Juan Pinazo

On Thu, Apr 25, 2013 at 1:54 PM, truedat101 notifications@github.comwrote:

Currently doesn't allow photo upload. We probably need to add a mim content uploader to our server. I'll take a look at what I've used in the past for this.

— Reply to this email directly or view it on GitHub< https://github.com/SMILEConsortium/node-smile-server/issues/14> .

— Reply to this email directly or view it on GitHubhttps://github.com/SMILEConsortium/node-smile-server/issues/14#issuecomment-17043950 .

pinazo commented 11 years ago

Ok.


Juan Pinazo

On Thu, Apr 25, 2013 at 7:55 PM, truedat101 notifications@github.comwrote:

Yes. You are right. The SMILE Student Web app doesn't handle image upload yet.

On Thu, Apr 25, 2013 at 3:14 PM, Juan Pinazo notifications@github.comwrote:

Isn't it the base64 picture upload?


Juan Pinazo

On Thu, Apr 25, 2013 at 1:54 PM, truedat101 notifications@github.comwrote:

Currently doesn't allow photo upload. We probably need to add a mim content uploader to our server. I'll take a look at what I've used in the past for this.

— Reply to this email directly or view it on GitHub< https://github.com/SMILEConsortium/node-smile-server/issues/14> .

— Reply to this email directly or view it on GitHub< https://github.com/SMILEConsortium/node-smile-server/issues/14#issuecomment-17043950>

.

— Reply to this email directly or view it on GitHubhttps://github.com/SMILEConsortium/node-smile-server/issues/14#issuecomment-17045846 .

pinazo commented 11 years ago

David, any details on how this should be implemented? I mean what route, image identification, what library, etc.

truedat101 commented 11 years ago

Juan, take a look at the smile student Web route.   If you run the server, go to port 80, and click on smile student Web. In firebug you can quickly see which sources are used. Sent from my BlackBerry 10 smartphone. From: Juan PinazoSent: Sunday, May 5, 2013 5:24 PMTo: SMILEConsortium/node-smile-serverReply To: SMILEConsortium/node-smile-serverCc: truedat101Subject: Re: [node-smile-server] Add photo upload to SMILE Student Web (#14)David, any details on how this should be implemented? I mean what route, image identification, what library, etc.

—Reply to this email directly or view it on GitHub.

pinazo commented 11 years ago

David, I am a bit lost on this issue. IRRC there is an online global web application running. Could you send me the url and/or more details on what should be done?

truedat101 commented 11 years ago

We aren't going to be dealing with the SMILE Global application at the moment. In our sources, we have smile-student.html which handles SMILE Student Web. It's a web client. We can add the image upload to the make questions phase implementation.

pinazo commented 11 years ago

Ok, gotcha.

truedat101 commented 11 years ago

sweet. Any idea whether we need a max upload size. I'm thinking if they go into a digital camera file, say like this one: http://kenrockwell.com/trips/2009-10/images/L1004220-cs2.jpg

this can either crash the plug computer, or will likely crash the android app. (I verified it does crash the android app). Let's prevent uploads bigger than 2MB.

I'll reopen.

truedat101 commented 11 years ago

Also, can you remove the green file upload box after submit? If that's a problem to do I can do it. Basically you'd add this in the form reset.

truedat101 commented 11 years ago

I'll add some logic to the android teacher app to avoid opening files too large.

truedat101 commented 10 years ago

We can fix the upload to large logic in the client. Need to add the image to the view after the upload. For now we fade out the success UI and put some text to say image is uploaded.

truedat101 commented 10 years ago

Just need to add the photo to the layout and close this.

truedat101 commented 10 years ago

Another problem is that once you do an upload, I've removed the upload interface. Need to keep that uploader around, but remove the "status" message. We don't want to allow multiple uploads.

truedat101 commented 10 years ago

For whatever reason, I can't get a computed observable to notify when pic is updated. Will look into this later. So we need to add an extra attibute, picdatauri, which is the data uri prefix for images with binary data inline, and the pic.

truedat101 commented 10 years ago

Also, for now, let's only accept jpegs, and we can look into png and gif later.

truedat101 commented 10 years ago

Closing.

truedat101 commented 10 years ago

Reactivate png, gif, uploads.