SMILEConsortium / node-smile-server

3 stars 4 forks source link

Teacher needs the server to support "retake" #15

Open truedat101 opened 11 years ago

truedat101 commented 11 years ago

There is a new message for restart. We need to pass this through and change game state, which involves keeping all the students, keeping the questions, removing the score data, and put the game into start answering questions state.

truedat101 commented 11 years ago

This is a child of: https://github.com/SMILEConsortium/smileplug-bsp/issues/9

truedat101 commented 11 years ago

This is high priority.

truedat101 commented 11 years ago

I need to provide a link to the source with the new Command Protocol that exists on the SMILE Student and Teacher Desktop repositories.

truedat101 commented 11 years ago

Student source on adhoc branch: https://github.com/SMILEConsortium/smile_teacher_desktop/tree/adhoc should contain details of the command protocol for retake.

truedat101 commented 11 years ago

Teacher java desktop source on adhoc branch: https://github.com/SMILEConsortium/smile_teacher_desktop/tree/adhoc

pinazo commented 11 years ago

As I could see in the smile_teacher_desktop code, server needs to support a message called RE_TAKEn, where n is the sequence of retake. As far as I can see, we don't need to take control of the number of retakes, is that correct?

truedat101 commented 11 years ago

Hmm, I'm not sure. I'll need to run the teacher desktop app.    I think your assumption is correct.  Sent from my BlackBerry 10 smartphone. From: Juan PinazoSent: Saturday, May 18, 2013 2:36 PMTo: SMILEConsortium/node-smile-serverReply To: SMILEConsortium/node-smile-serverCc: truedat101Subject: Re: [node-smile-server] Teacher needs the server to support "retake" (#15)As I could see in the smile_teacher_desktop code, server needs to support a message called RE_TAKEn, where n is the sequence of retake. As far as I can see, we don't need to take control of the number of retakes, is that correct?

—Reply to this email directly or view it on GitHub.

truedat101 commented 11 years ago

We may need to explore this issue later depending on how things work out with the RETAKEn n value.

truedat101 commented 11 years ago

Just adding a comment for Thiago so he can review for what needs to be done for teacher: https://github.com/SMILEConsortium/smile_teacher_desktop/blob/adhoc/src/org/smilec/smile/teacher/HttpMsgForTeacher.java#L308

truedat101 commented 11 years ago

I'm going to re-open. This probably needs some more code to interoperate with the teacher admin app. Also, appears to be missing a RE_TAKE test case.

truedat101 commented 11 years ago

Confirmed the teacher desktop app sends a number along with the RE_TAKE message. The message structure seems to follow this:

truedat101 commented 11 years ago

Student app on dev branch seems to be correct: https://github.com/SMILEConsortium/smile_student_android/blob/dev/src/org/smilec/smile/student/HttpMsgForStudent.java#L396

in that it will respond correctly to a retake.

truedat101 commented 11 years ago

I'll close this as soon as I can confirm from that I can trigger the right sequence from the teacher app.