SMILE Student Web doesn't submit answers properly

[truedat101]

Refer to: https://github.com/SMILEConsortium/smile_teacher_android/issues/13#issuecomment-20342174

[truedat101]

To reproduce:

• Start smile server
• Have teacher start a session
• Student Web interface should submit answers
• Note, in teacher app student results do not show up.

[chrqls]

Student results are visible in my teacher app.

[truedat101]

In the summary?   The smile student web app results (answers) don't show up. Sent from my BlackBerry 10 smartphone. From: Charles QuelosSent: Tuesday, July 2, 2013 2:58 PMTo: SMILEConsortium/node-smile-serverReply To: SMILEConsortium/node-smile-serverCc: truedat101Subject: Re: [node-smile-server] SMILE Student Web doesn't submit answers properly (#29)Student results are visible in my teacher app.

—Reply to this email directly or view it on GitHub.

[truedat101]

Are you using the web app or the android app?

On Tue, Jul 2, 2013 at 5:09 PM, Charles Quelos notifications@github.comwrote:

My student app cannot see the results. The button is disabled.

— Reply to this email directly or view it on GitHubhttps://github.com/SMILEConsortium/node-smile-server/issues/29#issuecomment-20387803 .

[chrqls]

Ok, I cloned a new student android app and I can see the results now. In the student android app, I can see through the results my name, my score and for each question if I was right or wrong. In the teacher android app, if I scroll on the right, I can consult the questions, their answer and their author. Is that what you need to know ?

[truedat101]

No, the issue is in the SMILE Student Web application. If you can:

1) Run the smile server 2) Hit SMILE Student web: go to http://localhost:80 3) Click on SMILE Student Web link 4) Login 5) Run the session 6) Show Results 7) You'll see that in the teacher app, the student results for the SMILE Web don't show up in the scoreboard.

Thiago called out an area where possibly we have a problem. I thought this was a problem with the teacher app possibly, but maybe we didn't push the score up.

On Tue, Jul 2, 2013 at 5:21 PM, Charles Quelos notifications@github.comwrote:

Ok, I cloned a new student android app and I can see the results now. In the student android app, I can see through the results my name, my score and for each question if I was right or wrong. In the teacher android app, if I scroll on the right, I can consult the questions, their answer and their author. Is that what you need to know ?

— Reply to this email directly or view it on GitHubhttps://github.com/SMILEConsortium/node-smile-server/issues/29#issuecomment-20388258 .

[chrqls]

When I run the session, I am blocked just after sending my question to the server. I have the following pop up: "Done. Please wait for the rest of the students to finish Creating Questions"

[truedat101]

So you aren't able to enter answer questions phase? Sent from my BlackBerry 10 smartphone. From: Charles QuelosSent: Tuesday, July 2, 2013 7:42 PMTo: SMILEConsortium/node-smile-serverReply To: SMILEConsortium/node-smile-serverCc: truedat101Subject: Re: [node-smile-server] SMILE Student Web doesn't submit answers properly (#29)When I run the session, I am blocked just after sending my question to the server. I have the following pop up: "Done. Please wait for the rest of the students to finish Creating Questions"

—Reply to this email directly or view it on GitHub.

[truedat101]

I can get questions sent by smile student web  Sent from my BlackBerry 10 smartphone. From: Charles QuelosSent: Tuesday, July 2, 2013 7:42 PMTo: SMILEConsortium/node-smile-serverReply To: SMILEConsortium/node-smile-serverCc: truedat101Subject: Re: [node-smile-server] SMILE Student Web doesn't submit answers properly (#29)When I run the session, I am blocked just after sending my question to the server. I have the following pop up: "Done. Please wait for the rest of the students to finish Creating Questions"

—Reply to this email directly or view it on GitHub.

[truedat101]

I then click get results and student gets results  Sent from my BlackBerry 10 smartphone. From: Charles QuelosSent: Tuesday, July 2, 2013 7:42 PMTo: SMILEConsortium/node-smile-serverReply To: SMILEConsortium/node-smile-serverCc: truedat101Subject: Re: [node-smile-server] SMILE Student Web doesn't submit answers properly (#29)When I run the session, I am blocked just after sending my question to the server. I have the following pop up: "Done. Please wait for the rest of the students to finish Creating Questions"

—Reply to this email directly or view it on GitHub.

[truedat101]

Finally, look on the teacher tablet under questions.... no results show under student.   shows 0% even tho we got 7 right. Bug!!! Sent from my BlackBerry 10 smartphone. From: Charles QuelosSent: Tuesday, July 2, 2013 7:42 PMTo: SMILEConsortium/node-smile-serverReply To: SMILEConsortium/node-smile-serverCc: truedat101Subject: Re: [node-smile-server] SMILE Student Web doesn't submit answers properly (#29)When I run the session, I am blocked just after sending my question to the server. I have the following pop up: "Done. Please wait for the rest of the students to finish Creating Questions"

—Reply to this email directly or view it on GitHub.

[truedat101]

Darn, it didn't include my photos. But basically it all works great for the student, except that the questions panel for the teacher doesn't show any results from the student web version.

[truedat101]

Meaning that the teacher app questions tab shows 0% for submissions by the smile student web. This works fine for SMILE Student Android.

[truedat101]

Can you reproduce and then deep dive into this problem. Submit a pull request on the fix. Likely the fix is required in the SMILE Student Web app. Unless there is a real bug in the Android Teacher app.

[chrqls]

Ok. I reproducted that and finally I can even display the Scoreboard. I posted 2 questions, and on this board I have 2 lines with my answers, the answers, and rating.

[truedat101]

Key finding is that the SMILE Student Web submits JSON answers like this:

{"MYRATING":["5","5","5","5","5","5","1"],"MYANSWER":["2","4","1","4","2","4","4"],"NAME":"luyjuglj7162","TYPE":"ANSWER","IP":"127.0.0.66"},

Notice, that MYANSWERS array contains quotes around each answer. This is different from the android app, which submits the raw number. What we found is that the calculation done for the average questions scores and rankings globally were not including the web student submissions. This is because we were comparing a raw number score for the correct answer to the character string score, using === , which would return false. So even when the answers were correct, they were not being scored for the global rankings.

[truedat101]

Closing

[truedat101]

Not merged on dev (Pirate says ARRRRRG!).

Need to cherry-pick 59da36b

[truedat101]

Can't tell for sure but doesn't seem this fix is working. I see we did get it onto dev, no idea why I did a pull request onto master.

[truedat101]

False alarm, this fix was ok, it was an optimization added later that was a problem.

[truedat101]

Remove the scoring optimization.