SMILEConsortium / node-smile-server

3 stars 4 forks source link

If the student adds a question and they have an invalid IP address, we add the question and then send back error 500 #41

Open truedat101 opened 10 years ago

truedat101 commented 10 years ago

There are two problems. One is the client must handle the error 500. I think they should, though error 500 implies server error. This is really a bad request, so we should probably return error 400. But in either case, we should not add the question. Or we should simply add the user. This shouldn't happen very often but I can see it will happen when the user has stayed in a session at login prompt after a teacher resets the game.