Closed truedat101 closed 10 years ago
Bump release tag to 0.9.9b1 for testing.
@chrqls please use the following tags:
For smileplug-server: 1.0.1-jamsj For smileteacher-adm: 0.9.9b1-jamsj
What I suggest is using 1.0.1-jamsj from the server, and download and install the teacher apk from the server.
Ok for the tags. I was using the id of a merge commit.
Concerning the download, does the feature already exist? should I call a specific URI from the Nexus 7 browser? like
If you go to local host in your browser, click on the link for smileteacher-adm from your tablet. Apk will download. Go to notice to ons, click on apk and install. Sent from my BlackBerry 10 smartphone. From: Charles QuelosSent: Tuesday, December 31, 2013 1:32 PMTo: SMILEConsortium/smile_teacher_androidReply To: SMILEConsortium/smile_teacher_androidCc: truedat101Subject: Re: [smile_teacher_android] Integration Test #1 SMILE Teacher + SMILE Plug Server (#106)Ok for the tags. I was using the id of a merge commit. Concerning the download, does the feature already exist? should I call a specific URI from the Nexus 7 browser? like /download/0.9.9b1-jamsj?
—Reply to this email directly or view it on GitHub.
@chrqls so if I read this correctly, Everything passed? Do you consider any items as must fix before we release?
I see, everything except for item 37 from Scenario 1.
yes. I am working on a cool feature for the teacher right now but I can have a look to the "no image available" after if you want.
On Thu, Jan 2, 2014 at 7:58 PM, truedat101 notifications@github.com wrote:
I see, everything except for item 37 from Scenario 1.
— Reply to this email directly or view it on GitHubhttps://github.com/SMILEConsortium/smile_teacher_android/issues/106#issuecomment-31504046 .
Great. Can you wrap up the "no image issue" today? Then I'll finalize the release. It should take more than a few hours to fix.
On Thu, Jan 2, 2014 at 8:10 PM, Charles Quelos notifications@github.comwrote:
yes. I am working on a cool feature for the teacher right now but I can have a look to the "no image available" after if you want. I also switched on server side README.md and README.txt. See here https://github.com/SMILEConsortium/node-smile-server/pull/104for
more detail.
Let me know if you have something else to add on teacher app.
On Thu, Jan 2, 2014 at 7:58 PM, truedat101 notifications@github.com wrote:
I see, everything except for item 37 from Scenario 1.
— Reply to this email directly or view it on GitHub< https://github.com/SMILEConsortium/smile_teacher_android/issues/106#issuecomment-31504046>
.
— Reply to this email directly or view it on GitHubhttps://github.com/SMILEConsortium/smile_teacher_android/issues/106#issuecomment-31504337 .
ok
On Fri, Jan 3, 2014 at 12:44 PM, truedat101 notifications@github.comwrote:
Great. Can you wrap up the "no image issue" today? Then I'll finalize the release. It should take more than a few hours to fix.
On Thu, Jan 2, 2014 at 8:10 PM, Charles Quelos notifications@github.comwrote:
yes. I am working on a cool feature for the teacher right now but I can have a look to the "no image available" after if you want. I also switched on server side README.md and README.txt. See here https://github.com/SMILEConsortium/node-smile-server/pull/104for
more detail.
Let me know if you have something else to add on teacher app.
On Thu, Jan 2, 2014 at 7:58 PM, truedat101 notifications@github.com wrote:
I see, everything except for item 37 from Scenario 1.
— Reply to this email directly or view it on GitHub<
https://github.com/SMILEConsortium/smile_teacher_android/issues/106#issuecomment-31504046>
.
— Reply to this email directly or view it on GitHub< https://github.com/SMILEConsortium/smile_teacher_android/issues/106#issuecomment-31504337>
.
— Reply to this email directly or view it on GitHubhttps://github.com/SMILEConsortium/smile_teacher_android/issues/106#issuecomment-31552137 .
@truedat101,
I really don't know what is happening now with my network but I can do anything correctly.
I understand that for now we have the "No image available" message because there is a onclick="alert(
in smile-iqmanager.html:
<tbody data-bind="foreach: iqdata">
<tr class="iq-grid" data-bind="attr: {id: $index}">
<td data-bind="text: $index()+1">1</td>
<td data-bind="text: Q">Where was it?</td>
<td data-bind="text: O1">Drawer</td>
<td data-bind="text: O2">Shelf</td>
<td data-bind="text: O3">TV</td>
<td data-bind="text: O4">Floor</td>
<td data-bind="text: A">3</td>
<td><a class="tiny button" href="#" onclick="alert('No Images Available'); return false;"> <img src="images/photo-icon.png" /> </a></td>
</tr>
</tbody>
Knockout give us a way to make our foreach on iqdata
. So I have to find a way to get all the imageurl from this iqdata
.
I think that the 2 functions we have to fix in smileiqmanager.js are function loadIQSet(evtdata, cb)
and function loadSession(evtdata, cb)
but impossible to continue my tests for now because of my network problems.
I wanted to see how the thing is working on smile web student to display the image.
In smile-student.html, the <img />
tag looks like this:
<img data-bind="attr: { src: picdatauri}" />
Can you review the knockout.js information on data-bind attribute? This is an MVC pattern attribute which binds the model to the view. So if you have data for the view, it will be presented. In our case, we need to, for any legit have a src attribute, right? So typically a src attribute is a URL. In our case, we are going to provide BASE64 encoded data. See how I do this on the student html, where I upload an image. We use a special URI to bind that data. The first step here is to detect whether Question.PIC is defined. If it is defined, then present the button. Otherwise, hide the button. JQuery has nice routines to hide and unhide things.
On Sat, Jan 4, 2014 at 7:59 PM, Charles Quelos notifications@github.comwrote:
David,
I really don't know what is happening now with my network but I can do anything correctly.
I understand that for now we have the "No image available" message because there is a onclick="alert( in smile-iqmanager.html:
1 Where was it? Drawer Shelf TV Floor 3 Knockout give us a way to make our foreach on iqdata. So I have to find a way to get all the imageurl from this iqdata.
I think that the 2 functions we have to fix in smileiqmanager.js are function loadIQSet(evtdata, cb) and function loadSession(evtdata, cb) but impossible to continue my tests for now because of my network problems.
I wanted to see how the thing is working on smile web student to display the image. In smile-student.html, the tag looks like this:
— Reply to this email directly or view it on GitHubhttps://github.com/SMILEConsortium/smile_teacher_android/issues/106#issuecomment-31595727 .
@chrqls can you move all the discussion related to this issue with images in the iqset over to: https://github.com/SMILEConsortium/node-smile-server/issues/74
Closing. Looks like the first integration test succeeds.
We need to complete a full batch of testing against the current versions. The description below is a complete matrix of the testing needed. The task will be to run through a complete integration test using the test plan below. Copy the results into subsequent comments to this issue. It is expected that complete test runs may not be possible if there are P1 issues found. We may need to re-run the test plan. In these cases, provide a new cut-n-paste of the results below with details of the test run. We must only be testing tagged & released code at this point. @truedat101 will provide the tags to use for testing.
Successful completion will allow us to continue with a test against the firmware on a SMILE Plug: https://github.com/SMILEConsortium/smileplug-bsp/issues/19
Test Plan
DATE:, < INSERT DATE > Tester Github ID:, < INSERT TESTER ID > SMILE Android Version:,< INSERT VERSION > SMILE Server Version:, < INSERT VERSION > HOST OS:, < INSERT VERSION > Android Device Model:, < INSERT MODEL > Android OS Version:, < INSERT OS VERSION > Android Browser & Version:, < INSERT BROWSER and VERSION > *Desktop Browser & Version, < INSERT BROWSER and VERSION > Number of Student Web Clients:, 3
Scenario 1: Run session and let students create the questions
Scenario 2: Run session and use prepared questions
Scenario 3: One-time things to verify
Scenario 4: Repeat Scenario 2, but use 15 Web Clients (Use browser on server host, use http://localhost, with each client in a tab)