All Column Headers in question tab and student data should be sortable after the teacher clicks on "Show Results"

[truedat101]

Please implement sortable tabs.

[truedat101]

Please prioritize this before working on anything else. Idea is to have sortable column headers for the scores and ratings in the students tab

[truedat101]

Presumably the student names should be sortable as well.

[thiagofnogueira]

Let me know if I am right. Would you like the "Students Tab" to be sorted by Score in the Results phase, and the "Question Tab" sorted by "rating", right? Because in the "Questions Tab" it is always sorted by the "%Correct" column and in the "Students Tab" it is always already sorted by the "Score" column.

[truedat101]

                                                                                                                                                                                                                                                                      Sent from my BlackBerry 10 smartphone.                                                                                                                                                                                                                                        From: thiagofnogueiraSent: Wednesday, July 3, 2013 6:43 AMTo: SMILEConsortium/smile_teacher_androidReply To: SMILEConsortium/smile_teacher_androidCc: truedat101Subject: Re: [smile_teacher_android] All Column Headers in question tab and student  data should be sortable after the teacher clicks on "Show Results" (#17)After show results is sent, we don't need to auto sort, so columns should be sortable.  Let me know if I am right. Would you like the "Students Tab" to be sorted  by Score in the Results phase, and the "Question Tab" sorted by "rating", right? Because in the "Questions Tab" it is always sorted by the "%Correct" column.

—Reply to this email directly or view it on GitHub.

[thiagofnogueira]

Sorry, the answer don't came.

[thiagofnogueira]

Fixes #17

Please, check out if you agree!

[truedat101]

Charles will verify.

[thiagofnogueira]

Ok

[chrqls]

Ok , I confirm. Just after pressing "Show results", list of students is auto-sorted by score and list of questions is auto-sorted by average rating. The best is on the top, the crapest on the bottom.

[truedat101]

Hmm, sortable columns means that if you click the column header, you should be able to sort by any of the column headers. For names, it sorts alphabetically (ascending/descending) and for ratings (ascending/descending), and for scores (ascending descending). If you click heading once, it should reverse direction, click again, back to the other way. Does it do this?

On Wed, Jul 3, 2013 at 12:03 PM, Charles Quelos notifications@github.comwrote:

Ok , I confirm. Just after pressing "Show results", list of students is auto-sorted by score and list of questions is auto-sorted by average rating. The best is on the top, the crapest on the bottom.

— Reply to this email directly or view it on GitHubhttps://github.com/SMILEConsortium/smile_teacher_android/issues/17#issuecomment-20437968 .

[chrqls]

No, it does not. After pressing "Show results", tables are sorted but there is any possibility to click on column headers. For example, if two students have a different score, clicking several times on "Score" header won't change anything. The best score will keep the first position. FYI, I am on dev branch.

[truedat101]

I'll reopen. This pisses me off. It was clear that we wanted click on column headers to resort. commit b67beada31533dc24d18b277bde147337ba3b617 was supposed to "fix" this.

[truedat101]

This turned out to be extremely half-baked. @chrqls what I meant was that if I had requested sortable columns, that was not how this got implemented. I think I'd like to turn off whatever automatic sorting is there, because it is confusing. It's better to list the questions in order.

[truedat101]

I think what this does is dynamically sort while the session is active. I think it sorts on the highest scored, but not clear ... For now, the desired result is that it stops sorting after we hit show results. At that point, I don't want sorting. Will leave this open, but I think there's nothing to fix before this release.

[truedat101]

So I was wrong. After the show results is clicked, it switches to some other dumb sort. I think it sorts by the actual rating. Just stop sorting I think.

[truedat101]

I'll fix this.

[truedat101]

Ok so all this gets handled in QuestionsFragment. There is a routine called SortQuestionList() which is called. Added in comit ref: b67beada31533dc24d18b277bde147337ba3b617

[truedat101]

Just dump the line that calls this. It's not doing what I asked for. We wanted sortable columns.

[truedat101]

This is good enough for the release. Leave issue open so that someone eventually fixes this.