search

SMSTicket / sms-ticket

Android app which simplifies buying and using tickets for public transportation using SMS
Apache License 2.0
70 stars 30 forks source link

common-java:DuplicatedBlocks - Source files should not have any duplicated blocks #35

Closed georgekankava closed 8 years ago

georgekankava commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rule common-java:DuplicatedBlocks - Source files should not have any duplicated blocks. This pull request removes 80 minutes of technical debt. You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/common-java:DuplicatedBlocks Please let me know if you have any questions. George Kankava

davidvavra commented 8 years ago

This removes code duplication, it looks OK to merge. Have you tested in the app that it doesn't cause any bugs?

georgekankava commented 8 years ago

@davidvavra I was not able to test it locally but shouldn't have any bugs because logic is preserved as before, I just removed code duplications.