search

SMTG-Bham / ThermoParser

A tool for streamlining data analysis and visualisation for thermoelectrics and charge carrier transport in computational materials science.
https://smtg-bham.github.io/ThermoParser/
GNU Affero General Public License v3.0
41 stars 14 forks source link

[joss review] Tutorial 4 #87

Closed fnattino closed 5 months ago

fnattino commented 6 months ago

In Tutorial-04, what does the color of the dots in the waterfall plot represent? Is it contribution to the thermal conductivity? If this is the case, should one add a colorbar as in the similar gallery plot? I have tried to do so using tp.axes.small.two_h_colourbars(), but it produced an identical plot (without colorbar).

JOSS review issue

kbspooner commented 6 months ago

In this case it just the reflects the band index, which is now written in the introduction to the tutorial. The _colourbar axes modules only leave space for a colourbar, only the plot functions (or the user) makes the actual colourbar, which is returned by the add_projected_waterfall function, but not by the add_waterfall function. This is the default behaviour if a colourmap is specified in the add_waterfall function, but a single colour will give a single-colour plot (this is now also included in the tutorial).

fnattino commented 5 months ago

Thanks, all clear now!