SMUnlimited / AMAI

Advanced Melee Artificial Intelligence Mod For Warcraft 3
Other
199 stars 32 forks source link

Commander and translation issues #74

Closed jzy-chitong56 closed 2 years ago

jzy-chitong56 commented 2 years ago

mabey Previous button It should be on the top

my eai should fix Dialog only show title at first and Dialog cannot change language butinfinite paging , i can not help , so sorry(try fixing) it is here https://github.com/jzy-chitong56/AMAI/blob/master/Blizzard.eai

QQ图片20220904201409

SMUnlimited commented 2 years ago

These should be fixed already by my recent commits https://github.com/SMUnlimited/AMAI/commit/5a33db9aa327984762a665de895ff718bbc738bf and https://github.com/SMUnlimited/AMAI/commit/001703f1f83b99cc40e918815041b3d1823774c8

jzy-chitong56 commented 2 years ago
  • Dialog only show title at first

no fix ,here no title =image

and here , AI Setting language is ai language, now,Do not affect commands, maybe Command language settings should be put into AI Setting ,too. Not alone outside image

and dlgbutton_commander_language, no adapted language....

SMUnlimited commented 2 years ago

Aha I now reproduced the missing title. Seems to go wrong with the all ally button but will investigate.

AI language does not affect commands as the commander is not directly linked to AI's. You can set every AI to be a different language in the commander but responses to the commander will always be in one language because the commander is only translated to 1 language. The command language option makes that clearer its different instead of hiding away and is more customizeable.

The missing translation for command language suggests to me a bug in the translation logic as should at least default to english not blank text.

jzy-chitong56 commented 2 years ago

Aha I now reproduced the missing title. Seems to go wrong with the all ally button but will investigate.

AI language does not affect commands as the commander is not directly linked to AI's. You can set every AI to be a different language in the commander but responses to the commander will always be in one language because the commander is only translated to 1 language. The command language option makes that clearer its different instead of hiding away and is more customizeable.

The missing translation for command language suggests to me a bug in the translation logic as should at least default to english not blank text.

If you want to set the command language button Put it outside,maybe necessary to set the top, Because if I have more than 10 allies, The button perhaps will go to the second page

SMUnlimited commented 2 years ago

I missed some of your changes @jzy-chitong56 so those seem to help.

But I have got to rebuild the static dialogs on language change to get the translation selection to hold.

jzy-chitong56 commented 2 years ago

I missed some of your changes @jzy-chitong56 so those seem to help.

But I have got to rebuild the static dialogs on language change to get the translation selection to hold.

I want to help , but I cannot i fix...not very successful https://github.com/jzy-chitong56/AMAI/blob/2.6.x/TEST

know problems

jzy-chitong56 commented 2 years ago

@SMUnlimited I try one time the Dialogs have change language , but original Dialogs not cleared , new language button appears at the bottom maybe call DialogDestroy all Dialogs , Rebuild Dialogs and all button , the language can change

SMUnlimited commented 2 years ago

Solved

jzy-chitong56 commented 2 years ago

Solved if you need , i have W3C map (the map only run war3 1.32+) https://github.com/jzy-chitong56/amai-map (Install master - 2022-09-07 0:49 [UTC+0800] , It's the version of the Dialogs language you just “Solved”)

they used lua , so map cannot run amai , so i change to jass , but price is W3C command invalid I do duplicate removal map(Keep the latest version) At least, players have new map