search

SN-Koarashi / ig-helper

In Instagram, downloading is possible for both photos and videos from posts, as well as for stories, reels or profile picture.
GNU General Public License v3.0
42 stars 3 forks source link

Fix stories #35

Closed sn-o-w closed 3 months ago

sn-o-w commented 3 months ago

Instagram added another div

SN-Koarashi commented 3 months ago

Your changes will invalidate my page, so I think the AB test may also be different about the relative position of DOM elements.

sn-o-w commented 3 months ago

Your changes will invalidate my page, so I think the AB test may also be different about the relative position of DOM elements.

Huh?! I'm not sure which page you're referring to, but I couldn't find any pages that would be invalidated by my changes. 🤔

SN-Koarashi commented 3 months ago

When viewing the story page, your edit caused me to match the hidden element below instead of the story page element in the foreground.

sn-o-w commented 3 months ago

When viewing the story page, your edit caused me to match the hidden element below instead of the story page element in the foreground.

I have no idea how to debug this... This never happened to me. 🤔

SN-Koarashi commented 3 months ago

I'll try another way of writing it.

SN-Koarashi commented 3 months ago

Now you can try it out and see if this selection mode works for you. @sn-o-w

sn-o-w commented 3 months ago

@SN-Koarashi Hmmm. I have an idea. One sec, need to try it before telling you.

sn-o-w commented 3 months ago

Now you can try it out and see if this selection mode works for you. @sn-o-w

Nooooo, I'm experimenting with another CSS selector. 😂

sn-o-w commented 3 months ago

@SN-Koarashi Can you test if now is okay on your side? I reverted your commit and tried another CSS selector. This new selector might be better than before.

SN-Koarashi commented 3 months ago

This selection mode looks more concise, I think I'll just use this one. @sn-o-w