search

SN-Koarashi / ig-helper

In Instagram, downloading is possible for both photos and videos from posts, as well as for stories, reels or profile picture.
GNU General Public License v3.0
33 stars 2 forks source link

Getting a message that pops up saying max button creation #7

Closed thinkpad4 closed 5 months ago

thinkpad4 commented 5 months ago

@SN-Koarashi I saw this: Added button creation maximum try times. and it's causing a prompt that doesn't go away talking about max button creation. This is what it says, Trying to call button creation method reached to maximum try times. If you want to re-register method, please open script menu and press "Reload Script" button or hotkey "R" to reload main timer. Is it possible to remove this button creation feature please? When I get that popup I can't access the settings menu or the reload script option as they don't show. Thank you very much

SN-Koarashi commented 5 months ago

The reload script option is available in the script drop-down menu that appears after clicking on the extension. Also, could you please explain the timing when this pop-up window appears?

@thinkpad4

SN-Koarashi commented 5 months ago

Screenshot_2024-03-06-11-09-38-188_com.android.chrome~3.jpg

thinkpad4 commented 5 months ago

@SN-Koarashi I know that, but when I get the dialog box saying that I've reached the max button creation I can't clear it, I keep clicking OK and it just returns, and while it's showing I can't access the dropdown menu. Let me get a screenshot: https://i.imgur.com/KQSYkG6.jpeg

SN-Koarashi commented 5 months ago

@thinkpad4

I see you're using Violentmonkey, and according to another previous user, this extension has some issues with clearInterval.

https://github.com/violentmonkey/violentmonkey/issues/2042

thinkpad4 commented 5 months ago

@SN-Koarashi Is there a way to make your script work in violentmonkey? I have a lot of scripts and violentmonkey is very lightweight compared to tampermonkey

SN-Koarashi commented 5 months ago

@thinkpad4 You can try updating your extended version and make sure that this script is actually loaded as document-idle (i.e. the default)

thinkpad4 commented 5 months ago

@SN-Koarashi I have a solution for the time being, I'll use violentmonkey for all my scripts, EXCEPT this one, i'll install this only only on tampermonkey. Edit: I removed const maxCall = 200; let i = 0; from the script and it works good, and when I lose the buttons I can access the reload script option. So maybe not have it pop up a alert saying the max button calls have been reached. It's the dialog box that is causing the issue. Is it possible to add a setting to disable the maxcall and the alertbox from the script? Have it on by default so the function doesn't change but allow it to be disabled.

SN-Koarashi commented 5 months ago

Does the problem still occur when you change the load timing in the script settings to document-idle or the default value? @thinkpad4

SN-Koarashi commented 5 months ago

And is the console still outputting content without the page scroller moving?

thinkpad4 commented 5 months ago

It looks like Violentmonkey 2.18.1beta has fixed the issue. https://github.com/violentmonkey/violentmonkey/commit/6fb2544af4e8249dd5c0e1a3c3e1676f2d048fe4 It references the issue from violentmonkey github you posted above

SN-Koarashi commented 5 months ago

Does the issue still persist when you update to version 2.18.1beta?

thinkpad4 commented 5 months ago

It does NOT and I'm able to select reload script and the buttons show up right away

SN-Koarashi commented 5 months ago

It appears that the issue can be considered resolved if the situation no longer occurs.

thinkpad4 commented 5 months ago

Thank you for your help, I'll close this now. If it shows up again I'll reopen this

sn-o-w commented 5 months ago

Ummm... I just got the same error... On Violentmonkey 2.18.1 BETA...

Screenshot_20

Have no idea what's going on. 🤔

SN-Koarashi commented 5 months ago

@sn-o-w Does the window disappear after clicking OK? Or does it appear multiple times?

In addition, you can update the script to the latest version. In the latest version, when the termination condition is reached, only a warning will be displayed on the console and no alert window will appear.

SN-Koarashi commented 5 months ago

If you update to 2.18.1 BETA, this warning may still appear. When you click on a post on your profile page, it appears as a float (called a modal or dialog). At this point, if you press ESC or click elsewhere, this issue may still occur if you close the window quickly enough. This is caused by the execution interval of the timer in the script being slower than the rate at which you turn it off. This is also the reason why I will cancel the alert window in the new version and display it in the console instead.

thinkpad4 commented 5 months ago

@SN-Koarashi I'm not getting the warning anymore on 2.18.1 Beta, and the rare time I lose the buttons now the Alt+R brings them right back.

SN-Koarashi commented 5 months ago

@thinkpad4 Missing buttons are an occasional issue. My guess is that when the timer detects the element, although the Instagram element has already appeared, this element is an old element, not a new one (non-synchronous loading).

This problem is unavoidable (at least I haven't found a solution yet). It used to be possible to refresh the entire page with F5 to solve the problem, but this was too slow, so I added the function of reloading the main timer.

sn-o-w commented 5 months ago

@sn-o-w Does the window disappear after clicking OK? Or does it appear multiple times?

In addition, you can update the script to the latest version. In the latest version, when the termination condition is reached, only a warning will be displayed on the console and no alert window will appear.

If I recall correctly, it didn't disappear after I clicked OK.

I didn't reencounter it, so maybe the situation improved with the newest versions. 🤔