search

SNAS / openbmp

OpenBMP Server Collector
www.openbmp.org
Eclipse Public License 1.0
230 stars 76 forks source link

Support for RFC5549 #72

Open ayalaalex opened 6 years ago

ayalaalex commented 6 years ago

Advertising IPV4 networks with IPV6 NH https://tools.ietf.org/html/rfc5549

Right now if the Prefix is IPV4 openBMP will convert NH to IPV4 format, otherwise use IPV6 format.

if (nlri.nh_len > 16) memcpy(ip_raw, nlri.next_hop, 16); else memcpy(ip_raw, nlri.next_hop, nlri.nh_len);

inet_ntop(isIPv4 ? AF_INET : AF_INET6, ip_raw, ip_char, sizeof(ip_char));

ayalaalex commented 6 years ago

VPNV6 prefixes have similar issues: u*>i 10.20.1.132:1:3ffe::4207:100/120 100 None ::ffff:10.20.1.131 38271 524280

Gets stored as prefix with NH :: instead of ::ffff:10.20.1.131 also the path_id it sets it to 0 instead of 38271.

TimEvens commented 5 years ago

Thanks for the details. Will fix this in the coming weeks. There are some collector updates that need to be done.