search

SND-LHC / advsndsw

Software for AdvSND
1 stars 3 forks source link

Proper implementation of the detector geometry in TI18 #1

Open dcentanni opened 3 months ago

dcentanni commented 3 months ago

A proper implementation of the detector geometry in the TI18 tunnel is needed since so far a simple shape (TGeoBBox) is subtracted to the Tunnel shape as done here. Perhaps implementing the integration studies made by L. Krzempek in https://edms.cern.ch/document/3076501/0.1.

siilieva commented 4 weeks ago

An addition to this issue: When we go back to this topic, I think it'd be good to rename a bit the volumes, including their indices For example now there are volAdvTarget_1, but volAdvMuFilter_0 or Coil and VertCoil In my opinion the last example creates confusion as we typically use vertical in terms of orientation.

olantwin commented 4 weeks ago

Completely agreed. I think we can also remove the vol prefixes, especially as these are Nodes, so they are not even correct.

dcentanni commented 4 weeks ago

Agreed with all of your comments, I can say that some of them are there just for historical reasons. As soon as we decide a standard naming, I can start solving this kind of issue.