Hit position

[siilieva]

First AdvTarget tracking in place!

@olantwin, please xcheck the change in the Digi task regarding the local position coordinate used to determine the strip. With this change I get good comparison MC points-> MC hits comparisons:

ps to all reviewers: Feel free to skip the revision of the bulk changes in the tracker - it works and passes the pre-commit tests.

[olantwin]

Could you please make the analogous change for the MuFilter as well? Should be a matter of copy paste.

[siilieva]

Could you please make the analogous change for the MuFilter as well? Should be a matter of copy paste.

what about testing? Do we know it will provide correct result. I have not tested that system. ps. I can make a test tomorrow morning.

[olantwin]

I think a simple closure test would be good and also sufficient: are the true coordinates of the MC points contributing within between the end points returned by the geometry?

Probably won't be able to do it today, so if you could manage, that would be amazing.

[siilieva]

pushed the changes mentioned above by @olantwin as separate commits - will reorder and squash before the final rebase onto the main Fixed the AdvMuFilter strip determination and checked it using NStrips and also using the now commited 2dED:

note: the hitColour option for the display needs optimization in terms of timing performance - can be very slow for busy events.

[siilieva]

I'd normally complain about one-line if statements and commented code in the event display, but in the interest of time, we can fix those later :)

Thanks a lot for all these fixes and improvements!

Shall I rebase as is, or do you want to squash some commits together to have a nicer history?

I will quickly do some re-ordering and squashing :D

[olantwin]

Ok! Ping me in case another review is needed.

[siilieva]

Ok! Ping me in case another review is needed.

It is done and I will 'rebase' now. Looks good.