Fix missing include of ROOT types

[olantwin]

Only manual change is adding the missing RtypesCore.h include. This error is include-order dependent and only showed up now because apparently previously we always included RtypesCore somewhere else before including ShipUnit.h.

[olantwin]

This should definitely also be fixed in sndsw.

[siilieva]

@olantwin , can you confirm besides formatting, it is only the addition of the RtypesCore header that was changed? It is rather hard to compare when all lines are green.

[olantwin]

@olantwin , can you confirm besides formatting, it is only the addition of the RtypesCore header that was changed? It is rather hard to compare when all lines are green.

The include guard has also been renamed (to follow the common naming scheme), but all the contents of the file have not been touched.

[siilieva]

This should definitely also be fixed in sndsw. Go ahead :)

reminder, we have an issue on sndsw for units modules in sndsw - duplicating .py and .h ones (#213) Mostly the py module of the shipunit is being used in sndsw btw, so we are mostly insensitive this fix.

[olantwin]

This should definitely also be fixed in sndsw. Go ahead :)

reminder, we have an issue on sndsw for units modules in sndsw - duplicating .py and .h ones (#213) Mostly the py module of the shipunit is being used in sndsw btw, so we are mostly insensitive this fix.

It's still used in quite a few spots:

shipLHC/sndRecoTrack.cxx
4:#include "ShipUnit.h"

shipLHC/EmulsionDet.cxx
48:#include "ShipUnit.h"

shipLHC/MuFilter.cxx
40:#include "ShipUnit.h"

shipLHC/Scifi.cxx
34:#include "ShipUnit.h"

shipgen/sndlhcGSimpleNtpConverter.cxx
10:#include "ShipUnit.h"

analysis/tools/sndSciFiTools.h
5:#include "ShipUnit.h"

But indeed, a useful reminder to resolve #213

[siilieva]

mostly , not not at all, @olantwin :D

[OL: ftfy :p]

[olantwin]

Fair enough :D