search

SND-LHC / sndsw

SND@LHC experiment framework based on FairShip and FairRoot
6 stars 17 forks source link

Flags and Masks #229

Open siilieva opened 4 months ago

siilieva commented 4 months ago

The flag and fMasked for MuFilterHits and sndScifiHits are of type Float_t.

These are private class members for both classes. The public methods reading the flag and mask are booleans. Also the treatment of the private flag and mask in the classes' cxx are as if booleans.

This needs sorting out: the parameters' type float can be int or bool. Of course needs testing on MC and data to make sure the digi and conversion tasks work properly.

olantwin commented 4 months ago

the parameters' type float can be int or bool.

Not sure what you mean here.

About the issue generally: These clearly should be boolean, there is no sense to them being Float_t and casting back and forth is dangerous. Booleans might also save space on disk (if we wanted to, the entire mask fits into one Float_t).