search

SNEWS2 / SNEWS_Coincidence_System

Coincidence System backend for snews alert trigger
BSD 2-Clause "Simplified" License
1 stars 2 forks source link

Replacing the snews format checker #75

Open KaraMelih opened 11 months ago

KaraMelih commented 11 months ago

With https://github.com/SNEWS2/SNEWS_Publishing_Tools/pull/81 we are getting rid of the snews format checker, and instead validating the messages upon generation.

Previously we were using a script called snews format checker where the neutrino times, p values etc are checked for each message in a standalone script, and using the same script within the snews coincidence system to make sure that the message comes from snews pt and not a stray message injected into the stream -which might potentially crash the server if not ignored.

Now that we have gotten rid of that, we should either write something that checks the similar properties of each received message, or we can again use the snews_pt as a dependency and try to rebuild a new message and check if it self validates again.

I'm open to alternative suggestions.

KaraMelih commented 10 months ago

@sybenzvi this is the issue I was referring to. @justinvasel suggested to use Pydantic which we also had discussed in the past. It may now be a good time to reconsider it.

KaraMelih commented 3 weeks ago

to keep an eye on the issue, I mention it here. Being worked at here; https://github.com/SNEWS2/snews-data-formats @justinvasel