search

SNEWS2 / SNEWS_Coincidence_System

Coincidence System backend for snews alert trigger
BSD 2-Clause "Simplified" License
1 stars 2 forks source link

Sql datetime fix #83

Closed Storreslara closed 6 months ago

KaraMelih commented 9 months ago

I need to test these changes a little extensively.
The numpy datetime scares me, it does not always play nicely with the datetime.datetime objects. While it seems everything in CS homogeneously switched to numpy.datetime it might still be that messages from PT that are formatted with datetime.datetime might cause problems.

I will try to break things and see :D maybe json-serializing it removes any library-dependence

KaraMelih commented 6 months ago

Right now, the datetime changes here and here; https://github.com/SNEWS2/SNEWS_Publishing_Tools/pull/90 play nicely with each other. They can together be merged. There are minor issues as commented above, mostly (possibly) redundant functions. @Storreslara could you please check my comment and tell me if this function in the SQL script is needed?