search

SNEWS2 / SNEWS_Publishing_Tools

Publishing Tool for SNEWS
BSD 3-Clause "New" or "Revised" License
2 stars 2 forks source link

does snews_pt need so many specific package requirements? #78

Open sybenzvi opened 1 year ago

sybenzvi commented 1 year ago

I noticed the current requirements list in snews_pt is pretty specific about all package versions. This seems a bit excessive for most of the requirements, though any dependency on the hop client probably has to be tied to a specific hop minor release. Can we clean this up?

joesmolsky commented 1 year ago

Other than hop-client, I don't know if any packages need to be a specific version. I think python needs to be 3.7-3.10 and that is not included in the requirements file. Should it be?

It might be a couple weeks-months before I have time to look into this in detail and test different dependencies. I think @Storreslara or @KaraMelih made the original requirements file and might know more about if specific versions are required for any packages.

KaraMelih commented 1 year ago

I believe the Python version can be enforced within the setup.py file and not the requirements file.

hop-client and maybe click, setuptools, might require specific versions but the rest should be rather flexible. I agree that one of us should test and relax the requirements

sybenzvi commented 1 year ago

OK, I'll come back to this next week and see if we can eliminate the specific versioning for most of the requirements. If it causes problems we'll just roll back the changes.