Closed KaraMelih closed 4 months ago
@Storreslara could you also add a short test in the testing suite for this? Something to test weirdly formatted ISO times to make sure future updates do not get silently crashed somewhere
Also, see the discussion here #86 I wrote 9 test cases, and I think we should try to make it so that they are all working.
I quickly tested the branch, it seems to work nicely with the SQL_datetime_fix
It plays nicely with its counterpart in https://github.com/SNEWS2/SNEWS_Coincidence_System/pull/83 and ready to be merged.
We still keep the "snews+format_checker.py" to be used on the server side when double-validating the messages.
For now, this PR addresses the issue with ISO formats;
Valid
"2023-06-9999999:45:100000"
Should still be accepted with proper rounding
""2023-06-9999999:45:10"
"2023-06-9999999:45:1000001234"